Cleanup reflection usage in InputManagerEventInjectionStrategy.#2398
Merged
Conversation
copybara-service
Bot
force-pushed
the
piper_769778949
branch
from
4b4e329 to
abf206f
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
piper_769778949
branch
3 times, most recently
from
224e2d9 to
5d2c5c9
Compare
InputManagerEventInjectionStrategy unfortunately uses a heavy amount of reflection to access hidden Android APIs. This commit attempts to clean it up as follows: - use Context.getSystemService instead of InputManager.getInstance on APIs > 23. Retrieving a Context can be tricky when espresso is used outside of Instrumentation, so also change InputManager retrival to on demand. - directly call MotionEvent.setSource. It has been available as a SDK method since API 12 - copy in the InputManager constants instead of using reflection. These values have not changed - remove unnecessary caching and use ReflectiveMethod, which performs lazy caching instead. PiperOrigin-RevId: 770828718
copybara-service
Bot
force-pushed
the
piper_769778949
branch
from
5d2c5c9 to
fddcda4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup reflection usage in InputManagerEventInjectionStrategy.
InputManagerEventInjectionStrategy unfortunately uses a heavy
amount of reflection to access hidden Android APIs.
This commit attempts to clean it up as follows:
Retrieving a Context can be tricky when espresso is used outside of Instrumentation,
so also change InputManager retrival to on demand.